Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node types for process exitCode don't allow string #1175

Merged
merged 1 commit into from
May 6, 2024

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented May 6, 2024

What does this PR do?

at some point, node has gotten better typing for process.exitCode. strings are no longer allowed

What issues does this PR fix or reference?

https://github.com/forcedotcom/source-deploy-retrieve/actions/runs/8955181731/job/24595639380?pr=1305

@mshanemc mshanemc merged commit 06ef385 into main May 6, 2024
28 checks passed
@mshanemc mshanemc deleted the sm/node-types-for-process.exitCode branch May 6, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants