Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump libs #936

Merged
merged 5 commits into from
Nov 20, 2023
Merged

feat: bump libs #936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0704ed6
feat: bump libs
mdonnalley Nov 14, 2023
8b1bec9
fix: use __dirname
mdonnalley Nov 14, 2023
1b4f81f
fix: use cjs bin scripts
mdonnalley Nov 14, 2023
9c10def
Merge branch 'main' into mdonnalley/bump-libs
iowillhoit Nov 17, 2023
a280dd8
Merge branch 'main' into mdonnalley/bump-libs
mdonnalley Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions bin/dev
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion bin/dev.cmd
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
@echo off

node "%~dp0\dev" %*
node --loader ts-node/esm --no-warnings=ExperimentalWarning "%~dp0\dev" %*
6 changes: 6 additions & 0 deletions bin/dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env ts-node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you wanting ts-node here instead of #!/usr/bin/env -S node --loader ts-node/esm --no-warnings=ExperimentalWarning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually need the ts-node/esm loader since this is still a CJS plugin

// eslint-disable-next-line node/shebang, unicorn/prefer-top-level-await
(async () => {
const oclif = await import('@oclif/core');
await oclif.execute({ development: true, dir: __dirname });
})();
3 changes: 0 additions & 3 deletions bin/run
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion bin/run.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
@echo off

node "%~dp0\run" %*
node "%~dp0\run" %*
7 changes: 7 additions & 0 deletions bin/run.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/usr/bin/env node

// eslint-disable-next-line unicorn/prefer-top-level-await
(async () => {
const oclif = await import('@oclif/core');
await oclif.execute({ development: false, dir: __dirname });
})();
14 changes: 6 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"sf-release": "bin/run"
},
"dependencies": {
"@oclif/core": "^2.15.0",
"@oclif/core": "^3",
"@octokit/core": "^4.2.4",
"@octokit/plugin-paginate-rest": "^6.1.2",
"@octokit/plugin-throttling": "^5.2.3",
Expand All @@ -17,7 +17,7 @@
"@salesforce/kit": "^3.0.15",
"@salesforce/plugin-command-reference": "^3.0.46",
"@salesforce/plugin-trust": "^2.6.23",
"@salesforce/sf-plugins-core": "^3.1.28",
"@salesforce/sf-plugins-core": "^4",
"@salesforce/ts-types": "^2.0.9",
"aws-sdk": "^2.1499.0",
"chalk": "^4.1.0",
Expand All @@ -36,12 +36,11 @@
"@oclif/plugin-command-snapshot": "^4.0.16",
"@salesforce/dev-scripts": "^6.0.3",
"@salesforce/ts-sinon": "1.4.19",
"@swc/core": "1.3.39",
"@types/semver": "^7.5.4",
"@types/shelljs": "^0.8.15",
"aws-sdk-mock": "^5.8.0",
"eslint-plugin-sf-plugin": "^1.16.14",
"oclif": "^3.17.2",
"oclif": "^4",
"shx": "0.3.4",
"ts-node": "^10.9.1",
"typescript": "^5.2.2"
Expand Down Expand Up @@ -74,7 +73,6 @@
"@salesforce/plugin-trust"
],
"devPlugins": [
"@oclif/plugin-help",
"@oclif/plugin-command-snapshot",
"@salesforce/plugin-command-reference"
],
Expand Down Expand Up @@ -235,7 +233,7 @@
"output": []
},
"test:command-reference": {
"command": "\"./bin/dev\" commandreference:generate --erroronwarnings",
"command": "ts-node \"./bin/dev.js\" commandreference:generate --erroronwarnings",
"files": [
"src/**/*.ts",
"messages/**",
Expand All @@ -246,7 +244,7 @@
]
},
"test:deprecation-policy": {
"command": "\"./bin/dev\" snapshot:compare",
"command": "ts-node \"./bin/dev.js\" snapshot:compare",
"files": [
"src/**/*.ts"
],
Expand All @@ -256,7 +254,7 @@
]
},
"test:json-schema": {
"command": "\"./bin/dev\" schema:compare",
"command": "ts-node \"./bin/dev.js\" schema:compare",
"files": [
"src/**/*.ts",
"schemas"
Expand Down
Loading