Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split on comma #249

Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix: split on comma #249

merged 1 commit into from
Feb 8, 2023

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Feb 8, 2023

What does this PR do?

The code was splitting on a space char when it needed to be a comma.

What issues does this PR fix or reference?

@W-12490382@
forcedotcom/cli#1912

@shetzel shetzel requested a review from a team as a code owner February 8, 2023 17:36
@WillieRuemmele
Copy link
Contributor

QA Notes


before:

 ➜  sfdx package version list  -p 0Ho3i000000GmjfCAC,0Ho3i000000GmjVCAS,0Ho3i000000GmjpCAC
Error (1): The Package Id: 0Ho3i000000GmjfCAC,0Ho3i000000GmjVCAS,0Ho3i000000GmjpCAC isn't defined in the sfdx-project.json. Add it to the packageDirectories section and add the alias to packageAliases with its 0Ho ID.

after:

 ➜  sfdx package version list  -p 0Ho3i000000GmjfCAC,0Ho3i000000GmjVCAS,0Ho3i000000GmjpCAC
=== Package Versions [6]

 Package Name Namespace Version Name Version Subscriber Package Version Id Alias Installation Key Released Validation Skipped Ancestor Ancestor Version Branch 
 ──────────── ───────── ──────────── ─────── ───────────────────────────── ───── ──────────────── ──────── ────────────────── ──────── ──────────────── ────── 
 orgInDep               ver 0.1      0.1.0.1 04t3i000002OUFTAA4                  false            false    false              N/A      N/A                     
 testWR                 ver 0.1      0.1.0.1 04t3i000002OUFnAAO                  false            false    false              N/A      N/A   

❓:

 ➜  sfdx package version list  -p "0Ho3i000000GmjfCAC, 0Ho3i000000GmjVCAS, 0Ho3i000000GmjpCAC"
Error (1): The id [ 0Ho3i000000GmjVCAS] is invalid. It must start with "0Ho".

seems like we could fix in the flag validation to trim() then validate 🤷‍♂️

@WillieRuemmele WillieRuemmele merged commit 2ca1fa3 into main Feb 8, 2023
@WillieRuemmele WillieRuemmele deleted the sh/list-multiple-packages branch February 8, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants