Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open a flow #829

Merged
merged 2 commits into from
Oct 13, 2023
Merged

feat: open a flow #829

merged 2 commits into from
Oct 13, 2023

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

org:open --source-file can open a flow in flow builder

What issues does this PR fix or reference?

forcedotcom/cli#2519
@W-14287109@

messages/open.md Outdated

# FlowIdNotFound

No ID not found for Flow %s .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: we should move the . to be at the end of the word, not .

@@ -65,6 +66,15 @@ describe('test org:open command', () => {
expect(result.url).to.include('/visualEditor/appBuilder.app?pageId');
});

it('should produce the URL for an existing flow', () => {
const result = execCmd<OrgOpenOutput>(`force:source:open --source-file ${flowPath} --url-only --json`, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to be using the deprecated command here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, just that the others were. A mix is probably best.

@WillieRuemmele
Copy link
Contributor

QA Notes


setup

create a flow, and pull it into the project

sf org open --source-file force-app/main/default/flows/my_flow-meta.xml =>
image

@WillieRuemmele WillieRuemmele merged commit d50c8fe into main Oct 13, 2023
9 checks passed
@WillieRuemmele WillieRuemmele deleted the sm/open-a-flow branch October 13, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants