Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sm/email-and-source-org #681

Merged
merged 5 commits into from
May 16, 2023
Merged

Sm/email-and-source-org #681

merged 5 commits into from
May 16, 2023

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

flags that override the adminEmail and sourceOrg definitionFile props

What issues does this PR fix or reference?

@W-13191348@
forcedotcom/cli#2130

shetzel
shetzel reviewed May 16, 2023
View reviewed changes
src/commands/org/create/scratch.ts Outdated
@@ -86,6 +84,7 @@ export default class EnvCreateScratch extends SfCommand<ScratchCreateResponse> {
'duration-days': Flags.duration({
unit: 'days',
defaultValue: 7,
required: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. Setting the default the "fixed" way seems to do it better (make it clear that it can't be undefined).

that didn't used to work correctly, but got fixed (while Mike was in last, I think?)

WillieRuemmele
WillieRuemmele approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@WillieRuemmele WillieRuemmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay flags.

@WillieRuemmele
Copy link
Contributor

QA Notes

✅ : set adminEmail in config, create org, click on profile, boom, email matches
✅ : use --admin-email flag -> 💥
✅ : set in config, pass in as flag. flag will override config

✅ : --source-org flag validation, length, starts with 00D
✅ : error when edition is specified and --source-org

with dev hub signed up for org snapshot feature:
sf org create shape -v <devhub>
sf org list snapshot verify it's in output
✅ : sf org create scratch --source-org 00Dxxx... -v <devhub>
✅ : sourceOrg specified in scratch-def
✅ : flag overrides
✅ : error messages when source org is invalid

@WillieRuemmele WillieRuemmele merged commit e5b53d6 into main May 16, 2023
@WillieRuemmele WillieRuemmele deleted the sm/email-and-source-org branch May 16, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shetzel shetzel shetzel left review comments

@WillieRuemmele WillieRuemmele WillieRuemmele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshanemc @WillieRuemmele @shetzel