Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm/scratch-org-id #675

Merged
merged 3 commits into from
May 15, 2023
Merged

Sm/scratch-org-id #675

merged 3 commits into from
May 15, 2023

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

wrong field was being used to populate the orgId

What issues does this PR fix or reference?

forcedotcom/cli#2131
@W-13191817@

Copy link
Contributor

@WillieRuemmele WillieRuemmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good, but NUTs are failing and unrelated to your new assertions

@@ -74,6 +74,7 @@ describe('env:create:scratch async/resume', () => {
if (resp.status === 0) {
done = true;
expect(resp.result).to.have.all.keys(completeKeys);
expect(resp.result.orgId).to.match(/^00D.{15}/);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart

@WillieRuemmele
Copy link
Contributor

QA Notes


before:
org create scratch:
The 2SR ID was populated in result.scratchOrgInfo.Id, result.orgId

org resume scratch:
The 2SR ID was populated in result.scratchOrgInfo.Id, result.orgId

after:

org create scratch:
✅ The 00D ID was populated in result.orgId

org resume scratch:
✅ The 00D ID was populated in result.orgId

@WillieRuemmele WillieRuemmele merged commit 9448c2a into main May 15, 2023
@WillieRuemmele WillieRuemmele deleted the sm/scratch-org-id branch May 15, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants