feat: support targeting browser in "open" command #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an optional --browser flag to the open command to enable users to specify which browser application to use (e.g. Firefox, Chrome).
It does this by passing the argument through to the underlying "open" package.
An example (on mac) is;
$ sfdx force:org:open -u MyAlias -b "chrome"This is a replica - more or less - of what was in #100 , but I was a plum and forgot to actually commit and push the last set of changes. With the amount of time and commits that have passed I thought it were best to rebase and create a new PR, instead of polluting it with lots of unrelated changes/merges etc.
What issues does this PR fix or reference?
This addresses the feature request #1015