fix: match on loginUrl/instanceUrl of ScratchOrgInfo if username does not match #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When running
sf org displaywith a target-org that is not the scratch org admin user, the code would not match the ScratchOrgInfo SignupUser and would throw an error that the dev hub does not have a scratch org record with the provided org ID. The code now tries to match the ScratchOrgInfo.LoginUrl with the target-org's instanceUrl as an additional way to match. With this change, a user created within the scratch org can also have org details displayed when that user is the target-org username.What issues does this PR fix or reference?
@W-17545444@