feat!: migrate to ESM #77
Conversation
BREAKING CHANGES: ESM and node 18 minimum
| @@ -192,7 +192,7 @@ | |||
| ] | |||
| }, | |||
| "test:deprecation-policy": { | |||
| "command": "\"./bin/dev\" snapshot:compare", | |||
| "command": "ts-node \"./bin/dev.js\" snapshot:compare", | |||
There was a problem hiding this comment.
| @@ -74,3 +74,9 @@ export const descriptionTransform = (description: string): string => | |||
| ) | |||
| // remove empty lines | |||
| .replace(/\n{2,}/gm, '\n'); | |||
|
|
|||
| export default { | |||
There was a problem hiding this comment.
is this needed? Did it not work to just import the functions?
There was a problem hiding this comment.
What I've found is that if you intend to stub something it needs to be imported the same way by both the source file and the test file. On top of that, sinon needs to have a module to stub instead of the function itself.
That means that sinon needs import things from 'discoveryQuery, which means that the source file has to do the same.
There was a problem hiding this comment.
eww. That's going to be dangerous. Put that on your list of "things you need to know about ESM"
There was a problem hiding this comment.
I also don't like that "mockability for tests" is driving the code structure. Maybe something like esmock could let tests handle this kind of thing?
https://github.com/iambumblehead/esmock/wiki
and also help with all the node:foo stuff?
What does this PR do?
Migrate to ESM
What issues does this PR fix or reference?
@W-14374849@