Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add warning when no proxy env vars are set #850

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Aug 28, 2024

What does this PR do?

adds a warning when no proxy env vars are set. updates tests.

What issues does this PR fix or reference?

@W-16510822@

@shetzel shetzel requested a review from a team as a code owner August 28, 2024 16:00
@cristiand391
Copy link
Member

QA notes

✅ can see warning about current state of NO_PROXY support when NO_PROXY or no_proxy is set

@cristiand391 cristiand391 merged commit 99fef04 into main Aug 28, 2024
15 checks passed
@cristiand391 cristiand391 deleted the sh/proxy-env-vars branch August 28, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants