fix: rightfully manipulate package json topics for dev:generate:command #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the existing Object spread merge does not play right here. Replaced by using lodash.defaultsDeep. defaultsDeep instead of merge to not replace existing keys/comments etc
|
Thanks for the contribution! Before we can merge this, we need @KevinGossentCap to sign the Salesforce Inc. Contributor License Agreement. |
|
@mshanemc that's for you :) |
mshanemc
approved these changes
Jun 6, 2023
|
This issue has been linked to a new work item: W-13544439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the existing Object spread merge does not play right here. Replaced by using lodash.defaultsDeep.
defaultsDeep instead of merge to not replace existing keys/comments etc
What does this PR do?
Fixes the modification of topics in package.json in dev:generate:command
it considers anything already existing as the rule but permits adding things (topics)
What issues does this PR fix or reference?
forcedotcom/cli#1805