Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit 1 when any batch/record fails #601

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Jun 22, 2023

What does this PR do?

when any batch/record fails in the bulk api transaction, set the exitcode to 1

What issues does this PR fix or reference?

forcedotcom/cli#1648
@W-11509580@

QA:
create a project
create an org
Make a "bad" csv like this

Id
0000sdfsdfsdf

../bin/dev data:delete:bulk --sobject Account --file ../foo.csv --wait 50

@iowillhoit
Copy link
Contributor

Confirmed 👍

Screenshot 2023-06-28 at 10 51 20 AM

@iowillhoit iowillhoit self-requested a review June 28, 2023 15:52
@iowillhoit iowillhoit merged commit 154f18d into main Jun 28, 2023
@iowillhoit iowillhoit deleted the sm/exit-1-when-failed-batches branch June 28, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants