Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove csvtojson from pjson.files #445

Merged
merged 5 commits into from
Apr 14, 2023
Merged

chore: remove csvtojson from pjson.files #445

merged 5 commits into from
Apr 14, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Apr 14, 2023

forcedotcom/cli#2058
@W-13029145@

background

this plugin's original authors, bless their hearts, copy-pasted csvtojson and included it in files. That relied on certain deps being present, including bluebird, that they provided no way of ensuring. I think that worked ok until toolbelt was removed, and then this started failing during JIT without bluebird.

this PR's changes

  • remove csvtojson
  • add csv-parse (the one we use in plugin-data) as a normal dep
  • change a bit of code in the generate records command to use the new parser

@mshanemc mshanemc requested a review from WillieRuemmele April 14, 2023 17:40
@WillieRuemmele
Copy link
Contributor

QA Notes

not sure of any way to test the JIT-ability of a change while in a PR


✅ : refresh node_modules, global search for bluebird, no "real" results - a few nested deps have it
✅ : run commands from inside project, they work
✅ : delete node_modules see similar error, yarn install commands work

@WillieRuemmele WillieRuemmele merged commit c6f87cf into main Apr 14, 2023
@WillieRuemmele WillieRuemmele deleted the sm/csv-parse branch April 14, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants