Remove log:get number default #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes (and ignores) the default for the
get log --numberinteger. When the default is present it takes priority over thelogIdin the apex library here: https://github.com/forcedotcom/salesforcedx-apex/blob/main/src/logs/logService.ts#L57-L60With this removed, you still get an appropriate message when you do not pass either flag:
Error (1): To retrieve logs, specify the log ID or the number of logs.Not knowing how the apex library is being used, I feel it is safer to make the change here.
What issues does this PR fix or reference?
forcedotcom/cli#2006
@W-12726884@