Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change Tableau CRM to Analytics #165

Merged
merged 2 commits into from
Nov 3, 2022
Merged

fix: change Tableau CRM to Analytics #165

merged 2 commits into from
Nov 3, 2022

Conversation

smithgp
Copy link
Collaborator

@smithgp smithgp commented Nov 2, 2022

What does this PR do?

Change all Tableau CRM refs to Analytics

@W-12004227@

@smithgp smithgp requested a review from a team as a code owner November 2, 2022 19:42
@smithgp smithgp self-assigned this Nov 2, 2022
@mblumreich mblumreich self-requested a review November 3, 2022 14:21
Copy link
Contributor

@mblumreich mblumreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You could just go with "Analytics" so you don't have to do this again. I'm doing that in our dev docs.

@smithgp smithgp changed the title fix: change Tableau CRM to CRM Analytics fix: change Tableau CRM to Analytics Nov 3, 2022
@smithgp smithgp requested a review from mblumreich November 3, 2022 16:15
@@ -1,6 +1,6 @@
{
"name": "@salesforce/analytics",
"description": "Commands for working with Tableau CRM applications, assets, and services",
"description": "Commands for working with Salesforce Analytics applications, assets, and services",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows in npmjs.com, so I added the Salesforce for extra context there.

"tableau",
"tableaucrm",
"tableau crm",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving these here. These are really only used for when someone searches on npmjs.com.

Copy link
Contributor

@mblumreich mblumreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@smithgp smithgp merged commit f3390eb into main Nov 3, 2022
@smithgp smithgp deleted the wdx/crma branch November 3, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants