Bring back -h #104
Merged
Bring back -h #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To bring in plugin-help, I also reved @salesforce/core and @salesforce/command. That then needed some minor updates for changes to the types.
smithgp
commented
Apr 12, 2022
| @@ -5,9 +5,10 @@ | |||
| * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause | |||
| */ | |||
|
|
|||
| import { promises as fs } from 'fs'; | |||
There was a problem hiding this comment.
fs from core is basically the same as fs.promises
| @@ -5,7 +5,8 @@ | |||
| * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause | |||
| */ | |||
|
|
|||
| import { core } from '@salesforce/command'; | |||
| import { promises as fs } from 'fs'; | |||
| import * as core from '@salesforce/core'; | |||
There was a problem hiding this comment.
The core import above was never really the right way to import core; this is the right way.
| @@ -4,6 +4,10 @@ | |||
| "target": "ES2019", | |||
| "outDir": "lib", | |||
| "rootDir": "src", | |||
| "baseUrl": ".", | |||
| "paths": { | |||
| "@salesforce/core": ["node_modules/@salesforce/core"] | |||
There was a problem hiding this comment.
@salesforce/command re-exports a copy of @salesforce/core, which the typescript type checker picks up first (and causes problems) w/o this line.
reidaelliott
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oclif/plugin-helpback, which provides-h@salesforce/commandand@salesforce/corefsfrom@salesforce/core