fix: new eslint warnings

salesforcecli · May 13, 2024 · faff3df · faff3df
1 parent 3dbf02a
commit faff3df
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/src/lib/analytics/app/folder.ts b/src/lib/analytics/app/folder.ts
@@ -72,9 +72,17 @@ export default class Folder {
   public async create(body: CreateAppBody): Promise<string | undefined> {
     if (this.serverVersion >= 55.0 && body.templateSourceId) {
       if (!body.templateOptions) {
-        body.templateOptions = { dynamicOptions: { productionType: 'ATF_3_0', runtimeLogEntryLevel: 'Warning' } };
+        // eslint-disable-next-line no-param-reassign
+        body = {
+          ...body,
+          templateOptions: { dynamicOptions: { productionType: 'ATF_3_0', runtimeLogEntryLevel: 'Warning' } },
+        };
       } else if (!body.templateOptions.dynamicOptions) {
-        body.templateOptions.dynamicOptions = { productionType: 'ATF_3_0', runtimeLogEntryLevel: 'Warning' };
+        // eslint-disable-next-line no-param-reassign
+        body.templateOptions = {
+          ...body.templateOptions,
+          dynamicOptions: { productionType: 'ATF_3_0', runtimeLogEntryLevel: 'Warning' },
+        };
       }
     }
     const response = await connectRequest<AppFolder>(this.connection, {

diff --git a/src/lib/analytics/query/query.ts b/src/lib/analytics/query/query.ts
@@ -307,6 +307,7 @@ export default class QuerySvc {
           ux.table(
             records,
             columnNames.reduce<Ux.Table.Columns<Row>>((all, name) => {
+              // eslint-disable-next-line no-param-reassign
               all[name] = { header: name, get: (row) => convertRowValue(row[name]) };
               return all;
             }, {})

diff --git a/src/lib/analytics/utils.ts b/src/lib/analytics/utils.ts
@@ -63,6 +63,7 @@ export function generateTableColumns<R extends Ux.Table.Data>(
     if (mutute) {
       column = mutute(key, column);
     }
+    // eslint-disable-next-line no-param-reassign
     columns[key] = column;
     return columns;
   }, {});

diff --git a/test/.eslintrc.cjs b/test/.eslintrc.cjs
@@ -13,6 +13,7 @@ module.exports = {
   rules: {
     // Allow assert style expressions. i.e. expect(true).to.be.true
     'no-unused-expressions': 'off',
+    'no-param-reassign': 'off',
     'mocha/no-identical-title': 'error',
 
     // Return types are defined by the source code. Allows for quick overwrites.