feat: add new check to prevent TS direct dep #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
Jul 23, 2024
.github/workflows/unitTest.yml
Outdated
There was a problem hiding this comment.
most repos don't call this. They call the linux/windows directly.
There was a problem hiding this comment.
so we're either going to have to put it in every repo OR tuck it into something weird (ex: lockfile check or linux ut etc) that's already everywhere
There was a problem hiding this comment.
the devDeps are required for UTs to run though
mshanemc
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-15981337@
see:
forcedotcom/source-deploy-retrieve#1373
first commit, without TS dep, passes https://github.com/forcedotcom/source-deploy-retrieve/actions/runs/10045614955/job/27763259371
second commit, with TS dep, fails https://github.com/forcedotcom/source-deploy-retrieve/actions/runs/10045668116/job/27763423256
note: will need to change
@wr/noTSreference to@mainbefore merging