Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn about old array input #1813

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

mdonnalley
Copy link
Contributor

What does this PR do?

Warn users about using old-style of array input (e.g. --my-flag=val1,val2,val3) and suggest new style (e.g. --my-flag val1 --my-flag val2 --my-flag val3)

What issues does this PR fix or reference?

@W-16343745@
forcedotcom/cli#2928

@mshanemc
Copy link
Contributor

QA notes: using bin/run.js with org list sobject record-counts

the warning...
✅ appears when using the flag with 1 and >1 commas
✅ appears when using the flag with 1 trailing comma
✅ does not appear when not using the flag
✅ does not appear when using the flag without commas
✅ does not appear with \,
✅ does not appear with \\,

@mshanemc mshanemc merged commit 7f01bb9 into main Jul 29, 2024
33 checks passed
@mshanemc mshanemc deleted the mdonnalley/warn-about-commas branch July 29, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants