fix: auth with url when TESTKIT_HUB_USERNAME is passed (#345)

* fix: auth with url when TESTKIT_HUB_USERNAME is passed * fix: revert change, now determine desired auth strategy, configure env vars with transfer
salesforcecli · Nov 29, 2022 · cb58b2b · cb58b2b
1 parent d8d75e9
commit cb58b2b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/hubAuth.ts b/src/hubAuth.ts
@@ -101,6 +101,7 @@ export const testkitHubAuth = (homeDir: string, authStrategy: DevhubAuthStrategy
     }
     return;
   }
+
   if (authStrategy === 'AUTH_URL') {
     logger('trying to authenticate with AuthUrl');
 

diff --git a/src/testSession.ts b/src/testSession.ts
@@ -170,11 +170,14 @@ export class TestSession extends AsyncOptionalCreatable<TestSessionOptions> {
       JSON.stringify(JSON.parse(JSON.stringify(this.options)))
     );
 
-    const authStrategy =
+    let authStrategy =
       this.options.devhubAuthStrategy === 'AUTO' ? getAuthStrategy() : this.options.devhubAuthStrategy ?? 'NONE';
 
     transferExistingAuthToEnv(authStrategy);
 
+    authStrategy =
+      this.options.devhubAuthStrategy === 'AUTO' ? getAuthStrategy() : this.options.devhubAuthStrategy ?? 'NONE';
+
     // Set the homedir used by this test, on the TestSession and the process
     process.env.USERPROFILE = process.env.HOME = this.homeDir = env.getString('TESTKIT_HOMEDIR', this.dir);
-Original file line number
+Diff line change
@@ Expand Up @@
         }
         return;
       }
       if (authStrategy === 'AUTH_URL') {
         logger('trying to authenticate with AuthUrl');
@@ Expand Down @@