Skip to content

Commit

Permalink
fix: regex for new inquirer select (#610)
Browse files Browse the repository at this point in the history
* fix: regex for interactive lists

* docs: linkinator
  • Loading branch information
mshanemc authored Jan 12, 2024
1 parent d0f06a4 commit 75f1a16
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 8 deletions.
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
## Contributing

1. The [DEVELOPING](DEVELOPING.md) doc has details on how to set up your environment.
1. Familiarize yourself with the codebase by reading the [docs](docs), which you can generate locally by running `yarn docs`.
1. Create a new issue before starting your project so that we can keep track of
what you are trying to add/fix. That way, we can also offer suggestions or
let you know if there is already an effort in progress.
Expand Down
4 changes: 0 additions & 4 deletions DEVELOPING.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ This cleans all generated files and directories. Run `yarn clean-all` to also cl

This tests the typescript using ts-node.

### `yarn docs`

This generates documentation into [docs](docs).

### `yarn lint`

This lints all the typescript. If there are no errors/warnings
Expand Down
2 changes: 1 addition & 1 deletion LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2023, Salesforce.com, Inc.
Copyright (c) 2024, Salesforce.com, Inc.
All rights reserved.

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
[![NPM](https://img.shields.io/npm/v/@salesforce/cli-plugins-testkit.svg)](https://www.npmjs.com/package/@salesforce/cli-plugins-testkit)
[![CircleCI](https://circleci.com/gh/salesforcecli/cli-plugins-testkit.svg?style=svg&circle-token=2377ca31221869e9d13448313620486da80e595f)](https://circleci.com/gh/salesforcecli/cli-plugins-testkit)

# Description

Expand Down
5 changes: 4 additions & 1 deletion src/execCmd.ts
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,10 @@ export async function execInteractiveCmd(
const shouldScrollForAnswer = current.includes('❯') && scrollTarget;

if (shouldScrollForAnswer) {
const regex = /(?<=\s)(.*)/g;
// recent inquirer versions include a unicode character in the prompt that we need to strip out
// it's something like a backspace or a backline character used to type over existing output
// this generally removes all the "control" characters in the first section of unicode
const regex = /(?<=\s)([\u0020-\u00d7ff]+)/g;
const selected = (current.match(regex) ?? [''])[0].trim();
if (selected === scrollTarget) {
seen.add(matchingQuestion);
Expand Down

0 comments on commit 75f1a16

Please sign in to comment.