upgrade typescript-eslint to 8.0.1 (#440)

salesforce · Sep 5, 2024 · 93d550b · 93d550b
1 parent 07a7a4d
commit 93d550b
Show file tree

Hide file tree

Showing 5 changed files with 141 additions and 144 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -36,6 +36,7 @@ export default tseslint.config(
       '@typescript-eslint/explicit-function-return-type': 'off',
       '@typescript-eslint/no-var-requires': 'off',
       '@typescript-eslint/no-unused-vars': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
     },
   },
 )
diff --git a/lib/cookie/cookie.ts b/lib/cookie/cookie.ts
@@ -284,6 +284,7 @@ function fromJSON(str: unknown): Cookie | undefined {
   if (typeof str === 'string') {
     try {
       obj = JSON.parse(str)
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
     } catch (e) {
       return undefined
     }

diff --git a/lib/utils.ts b/lib/utils.ts
@@ -98,8 +98,9 @@ export function createPromiseCallback<T>(cb?: Callback<T>): PromiseCallback<T> {
       try {
         // If `err` is null, we know `result` must be `T`
         // The assertion isn't *strictly* correct, as `T` could be nullish, but, ehh, good enough...
+        if (err) reject(err)
         // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-        err ? reject(err) : resolve(result!)
+        else resolve(result!)
       } catch (e) {
         reject(e instanceof Error ? e : new Error())
       }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -129,7 +129,7 @@
     "ts-jest": "^29.2.2",
     "ts-node": "^10.9.2",
     "typescript": "5.5.3",
-    "typescript-eslint": "^7.16.1",
+    "typescript-eslint": "^8.0.1",
     "vows": "^0.8.3"
   },
   "dependencies": {