Allow prefix/suffix for generated version properties #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simontoens
reviewed
Mar 30, 2021
| Convenience method that returns a tuple of prefix and suffix to use for generated version properties. | ||
| """ | ||
| return (self.version_property_prefix, self.version_property_suffix) | ||
|
|
There was a problem hiding this comment.
This is fine, but I would just have 2 properties.... that's just less weird. 2 minutes later: ok I see why you did this. We probably need a better way to pass config through. Fine for now. I guess I would still say keep them separate here (2 @Property annotated methods), then pass them through the rest of the code base as a tuple
There was a problem hiding this comment.
Will do! Yeah, I was kind of hesitated between keeping less parameters passed around and making the property type clear
simontoens
approved these changes
Mar 30, 2021
dylanShark
force-pushed
the
allow_prefix_suffix
branch
from
a65e418 to
d448bf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.