Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(perf-benchmarks): fix displayed benchmark name #4922

Merged
merged 2 commits into from
Nov 25, 2024
Merged

chore(perf-benchmarks): fix displayed benchmark name #4922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d9a187
chore(perf-benchmarks): fix displayed benchmark name
nolanlawson Nov 22, 2024
5d9c6a0
fix: rename
nolanlawson Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/@lwc/perf-benchmarks/scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,14 +147,17 @@ async function processBenchmarkFile(benchmarkFile, directoryHash) {
const benchmarkFileBasename = path.basename(benchmarkFile);
const htmlFilename = path.join(targetDir, benchmarkFileBasename.replace('.js', '.html'));

// Generate a pretty name for the benchmark to display in Tachometer results
const splitFileName = benchmarkFile.split(path.sep);
const engineType = splitFileName[splitFileName.indexOf('__benchmarks__') + 1];
const benchmarkName = `${engineType}-${benchmarkFileBasename.split('.')[0]}`;

async function writeHtmlFile() {
const html = createHtml(benchmarkFile);
await writeFile(htmlFilename, html, 'utf8');
}

async function writeTachometerJsonFile() {
const engineType = benchmarkFile.includes('/engine-server/') ? 'server' : 'dom';
const benchmarkName = `${engineType}-${benchmarkFileBasename.split('.')[0]}`;
const cpuThrottlingRate =
typeof BENCHMARK_CPU_THROTTLING_RATE === 'number'
? BENCHMARK_CPU_THROTTLING_RATE
Expand Down
0 ...ine-hydrate/table-hydrate-1k.benchmark.js → ..._/hydration/table-hydrate-1k.benchmark.js
View file
Open in desktop
File renamed without changes.
0 ...-hydrate/tablecmp-hydrate-1k.benchmark.js → ...ydration/tablecmp-hydrate-1k.benchmark.js
View file
Open in desktop
File renamed without changes.