Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): use observable-membrane's read-only proxy #4802

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nolanlawson
Copy link
Collaborator

Details

Fixes #4799

We actually have 2 fewer test failures than before, and the read-only tests pass before and after, so this means I was way overthinking it when I did #4779.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@nolanlawson nolanlawson requested a review from a team as a code owner November 7, 2024 21:34
@nolanlawson
Copy link
Collaborator Author

These are the 2 fixed tests:

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[13/45]⎯

 FAIL  |lwc-ssr-compiler| src/__tests__/fixtures.spec.ts > fixtures > known-boolean-attributes/incorrect-tag-attr-pair/dynamic/index.js
Error: Snapshot `fixtures > known-boolean-attributes/incorrect-tag-attr-pair/dynamic/index.js 1` mismatched

- Expected
+ Received

+ Cannot convert object to primitive value

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[14/45]⎯

 FAIL  |lwc-ssr-compiler| src/__tests__/fixtures.spec.ts > fixtures > known-boolean-attributes/default-def-html-attributes/dynamic/index.js
Error: Snapshot `fixtures > known-boolean-attributes/default-def-html-attributes/dynamic/index.js 1` mismatched

- Expected
+ Received

+ Cannot convert object to primitive value

@@ -44,6 +44,7 @@
}
},
"devDependencies": {
"@lwc/shared": "8.7.0"
"@lwc/shared": "8.7.0",
"observable-membrane": "2.0.0"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets bundled into the dist file FWIW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cloneAndDeepFreeze with observable-membrane read-only proxy
1 participant