Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Template compiler should avoid outputting empty children array #2671

Closed
nolanlawson opened this issue Feb 2, 2022 · 1 comment · Fixed by #2685
Closed

[Perf] Template compiler should avoid outputting empty children array #2671

nolanlawson opened this issue Feb 2, 2022 · 1 comment · Fixed by #2685
Labels
BUG P3 enhancement

Comments

@nolanlawson
Copy link
Collaborator

As described in #2618 (comment), the compiler currently generates a lot of [] to denote empty children. This can just be made implicit in the h function:

lwc/packages/@lwc/engine-core/src/framework/api.ts

Lines 58 to 59 in 045f093

// [h]tml node
function h(sel: string, data: VElementData, children: VNodes): VElement {

@nolanlawson nolanlawson mentioned this issue Feb 2, 2022
Merged
@nolanlawson nolanlawson changed the title [Perf] Template compiler should avoid outputting empty child array [Perf] Template compiler should avoid outputting empty children array Feb 2, 2022
@uip-robot-zz
Copy link

This issue has been linked to a new work item: W-10660536

nolanlawson added a commit that referenced this issue Feb 8, 2022
@nolanlawson
perf(template-compiler): make empty children implicit
0ecf7e6 
Fixes #2671

W-10660536
@nolanlawson nolanlawson mentioned this issue Feb 8, 2022
Merged
nolanlawson added a commit that referenced this issue Feb 8, 2022
@nolanlawson
perf(template-compiler): make empty children implicit (#2685)
6795167 
Fixes #2671

W-10660536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG P3 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(template-compiler): make empty children implicit salesforce/lwc
2 participants
@nolanlawson @uip-robot-zz