feat: refactor module resolution (#1414)

* feat: refactor module resolution

* fix: refactor base on feedback

* fix: overrides

* fix: readDir

* fix: add copyright

* fix: upgrade best and minor fixes

packages/@lwc/compiler/src/rollup-plugins/module-resolver.ts

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: MIT
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
-import * as path from 'path';
+import path from 'path';
 import { Plugin } from 'rollup';
 import { ModuleResolutionErrors, generateCompilerError } from '@lwc/errors';
 

packages/@lwc/engine/package.json

@@ -23,9 +23,12 @@
         "@lwc/template-compiler": "1.0.2"
     },
     "lwc": {
-        "modules": {
-            "lwc": "dist/engine.js"
-        }
+        "modules": [
+            {
+                "name": "lwc",
+                "path": "dist/engine.js"
+            }
+        ]
     },
     "publishConfig": {
         "access": "public"

packages/@lwc/module-resolver/package.json

@@ -8,9 +8,6 @@
         "build": "tsc"
     },
     "license": "MIT",
-    "dependencies": {
-        "fast-glob": "~2.2.6"
-    },
     "files": [
         "dist/"
     ],

packages/@lwc/module-resolver/src/__tests__/fixtures/custom-resolution/custom-override.js

@@ -0,0 +1 @@
+export const x = 2;

packages/@lwc/module-resolver/src/__tests__/fixtures/custom-resolution/custom/module.js

@@ -0,0 +1 @@
+export const x = 1;

packages/@lwc/module-resolver/src/__tests__/fixtures/custom-resolution/lwc.config.json

@@ -0,0 +1,8 @@
+{
+    "modules": [
+        {
+            "name": "custom-module",
+            "path": "custom/module.js"
+        }
+    ]
+}

packages/@lwc/module-resolver/src/__tests__/fixtures/from-npm/lwc.config.json

@@ -0,0 +1,7 @@
+{
+    "modules": [
+        "@lwc/engine",
+        "@lwc/wire-service",
+        "@lwc/synthetic-shadow"
+    ]
+}

packages/@lwc/module-resolver/src/__tests__/fixtures/lwc.config.json

@@ -0,0 +1,5 @@
+{
+    "modules": [
+        "module-entries/"
+    ]
+}

packages/@lwc/module-resolver/src/__tests__/fixtures/module-entries/ns/cssEntry/cssEntry.css

@@ -0,0 +1 @@
+export const test = 1;

packages/@lwc/module-resolver/src/__tests__/fixtures/module-entries/ns/htmlEntry/htmlEntry.html

@@ -0,0 +1,3 @@
+<template>
+
+</template>

packages/@lwc/module-resolver/src/__tests__/fixtures/module-entries/ns/jsEntry/jsEntry.js

@@ -0,0 +1 @@
+export const test = 1;

packages/@lwc/module-resolver/src/__tests__/resolve.modules.spec.ts

@@ -0,0 +1,61 @@
+/*
+ * Copyright (c) 2018, salesforce.com, inc.
+ * All rights reserved.
+ * SPDX-License-Identifier: MIT
+ * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
+ */
+
+import path from 'path';
+import { resolveModules } from '../index';
+
+const FIXTURE_MODULE_ENTRIES = ['ns/cssEntry', 'ns/htmlEntry', 'ns/jsEntry'];
+
+describe('resolve modules', () => {
+    it('from directory', () => {
+        const modules = resolveModules({
+            rootDir: __dirname,
+            modules: ['fixtures/module-entries'],
+        });
+        const specifiers = modules.map(m => m.specifier);
+        expect(specifiers).toStrictEqual(FIXTURE_MODULE_ENTRIES);
+    });
+
+    it('from config', () => {
+        const moduleDir = path.join(__dirname, 'fixtures');
+        const modules = resolveModules({ rootDir: moduleDir });
+        const specifiers = modules.map(m => m.specifier);
+        expect(specifiers).toStrictEqual(FIXTURE_MODULE_ENTRIES);
+    });
+
+    it('from config resolving to npm', () => {
+        const moduleDir = path.join(__dirname, 'fixtures/from-npm');
+        const modules = resolveModules({ rootDir: moduleDir });
+        const specifiers = modules.map(m => m.specifier);
+        expect(specifiers).toStrictEqual(['lwc', 'wire-service', '@lwc/synthetic-shadow']);
+    });
+
+    it('from config resolving to custom modules', () => {
+        const moduleDir = path.join(__dirname, 'fixtures/custom-resolution');
+        const modules = resolveModules({ rootDir: moduleDir });
+        const specifiers = modules.map(m => m.specifier);
+        expect(specifiers).toStrictEqual(['custom-module']);
+    });
+
+    it('with configuration overrides resolving to custom modules', () => {
+        const moduleDir = path.join(__dirname, 'fixtures/custom-resolution');
+        const modules = resolveModules({
+            rootDir: moduleDir,
+            modules: [{ name: 'custom-module', path: 'custom-override.js' }],
+        });
+        const specifiers = modules.map(m => m.specifier);
+        const entries = modules.map(m => m.entry);
+        expect(specifiers).toStrictEqual(['custom-module']);
+        expect(entries).toStrictEqual([path.join(moduleDir, 'custom-override.js')]);
+    });
+
+    it('from api configuration', () => {
+        const modules = resolveModules({ modules: ['@lwc/engine'] });
+        const specifiers = modules.map(m => m.specifier);
+        expect(specifiers).toStrictEqual(['lwc']);
+    });
+});