fix(compiler): add default export support and enable strict mode (#1175)

salesforce · Apr 23, 2019 · a429824 · a429824
1 parent 26344d6
commit a429824
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 8 deletions.
diff --git a/packages/@lwc/compiler/src/__tests__/fixtures/expected-minify-no-comments.js b/packages/@lwc/compiler/src/__tests__/fixtures/expected-minify-no-comments.js
diff --git a/packages/@lwc/compiler/src/__tests__/fixtures/expected-prod-mode.js b/packages/@lwc/compiler/src/__tests__/fixtures/expected-prod-mode.js
diff --git a/packages/@lwc/compiler/src/__tests__/fixtures/expected-prod_compat-mode.js b/packages/@lwc/compiler/src/__tests__/fixtures/expected-prod_compat-mode.js
diff --git a/packages/@lwc/compiler/src/__tests__/regression.spec.ts b/packages/@lwc/compiler/src/__tests__/regression.spec.ts
@@ -10,7 +10,7 @@ import { readFixture, pretify } from './utils';
 describe('regression test', () => {
     it('#743 - Object rest spread throwing', async () => {
         const actual = `const base = { foo: true }; const res = { ...base, bar: false };`;
-        const expected = `define('x/foo', function () {
+        const expected = `define('x/foo', function () { 'use strict';
             function _objectSpread(target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i] != null ? arguments[i] : {}; var ownKeys = Object.keys(source); if (typeof Object.getOwnPropertySymbols === 'function') { ownKeys = ownKeys.concat(Object.getOwnPropertySymbols(source).filter(function (sym) { return Object.getOwnPropertyDescriptor(source, sym).enumerable; })); } ownKeys.forEach(function (key) { _defineProperty(target, key, source[key]); }); } return target; }
         function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
 

diff --git a/packages/@lwc/compiler/src/bundler/bundler.ts b/packages/@lwc/compiler/src/bundler/bundler.ts
@@ -122,8 +122,6 @@ export async function bundle(options: NormalizedCompilerOptions): Promise<Bundle
 
         const { output } = await rollupBundler.generate({
             amd: { id: namespace + '/' + name },
-            interop: false,
-            strict: false,
             sourcemap: outputConfig.sourcemap,
             format,
         });

diff --git a/packages/@lwc/compiler/src/rollup-plugins/__tests__/module-resolver.spec.ts b/packages/@lwc/compiler/src/rollup-plugins/__tests__/module-resolver.spec.ts
@@ -41,7 +41,7 @@ describe('module resolver', () => {
 
         expect(success).toBe(true);
         expect(pretify(result.code)).toBe(
-            pretify(`define('x/class_and_template', ['lwc'], function (lwc) {
+            pretify(`define('x/class_and_template', ['lwc'], function (lwc) { 'use strict';
                 function tmpl($api, $cmp, $slotset, $ctx) {
                     const {
                         t: api_text,
@@ -90,7 +90,7 @@ describe('module resolver', () => {
         const { success, result } = await compile(noOutputConfig);
         expect(success).toBe(true);
         expect(pretify(result.code)).toBe(
-            pretify(`define('x/class_and_template', ['lwc'], function (lwc) {
+            pretify(`define('x/class_and_template', ['lwc'], function (lwc) { 'use strict';
                 function tmpl($api, $cmp, $slotset, $ctx) {
                     const {
                         t: api_text,