Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress findings when conditions exist, except when --flag-all-risky-actions flag is included #303

Merged
merged 5 commits into from
Aug 19, 2023

Conversation

jacobappleton-orbis
Copy link
Contributor

What does this PR do?

What gif best describes this PR or how it makes you feel?

Completion checklist

  • Additions and changes have unit tests
  • The pull request has been appropriately labeled using the provided PR labels
  • GitHub actions automation is passing (make test, make lint, make security-test, make test-js)
  • [ ] If the UI contents or JavaScript files have been modified, generate a new example report:

@kmcquade
Copy link
Collaborator

kmcquade commented Aug 2, 2023

@jacobappleton-orbis - it looks like you ran the formatter across the code base. It's hard to read which parts of the PR actually changed the code vs. what was the formatter. Can you revert the files that are formatting related so I can just review the ones that introduce changes? Thanks :)

@salesforce-cla
Copy link

salesforce-cla bot commented Aug 2, 2023

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Dan Jacobson <d***@o***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@jacobappleton-orbis
Copy link
Contributor Author

@kmcquade I have removed the commit that performed the formatting. It appears that salesforce-cla bot now thinks that I have not signed the CLA, when I definitely have. Otherwise this should be in a good state now.

@jacobappleton-orbis
Copy link
Contributor Author

Ok, I think I've fixed the CLA issue as well.

@kmcquade
Copy link
Collaborator

kmcquade commented Aug 8, 2023

@jacobappleton-orbis unit tests and NodeJS tests look good. But looks like it's failing the mypy check. If you can make that fix, then happy to merge. Thanks!

@kmcquade kmcquade changed the title Fix 278 299 Suppress findings when conditions exist, except when --flag-all-risky-actions flag is included Aug 12, 2023
Copy link
Collaborator

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty and fixed the tiny type hint issue and since @kmcquade already gave his ok, so will I 😄

@gruebel gruebel merged commit dc37bd5 into salesforce:master Aug 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants