Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide remote javascript option to reduce size #125

Closed
kmcquade opened this issue Oct 12, 2020 · 1 comment
Closed

Provide remote javascript option to reduce size #125

kmcquade opened this issue Oct 12, 2020 · 1 comment
Assignees
@kmcquade

Comments

@kmcquade
Copy link
Collaborator

The reports are very large as-is. We should provide the option to have javascript code be remote.

We can have it be versioned like this:

<script src="https://raw.githubusercontent.com/salesforce/cloudsplaining/0.2.2/cloudsplaining/output/dist/js/chunk-vendors.js"></script>

Report template logic: https://github.com/salesforce/cloudsplaining/blob/master/cloudsplaining/output/report.py

Current template in use: https://github.com/salesforce/cloudsplaining/blob/master/cloudsplaining/output/template.html
@kmcquade kmcquade self-assigned this Oct 12, 2020
@kmcquade
Copy link
Collaborator Author

GitHub raw throws an error due to an incorrect mime type. TIL that JSDelivr already caches everything on GitHub, so we don't even need to push the script anywhere! Just going to use this instead of GItHub raw:

https://cdn.jsdelivr.net/gh/salesforce/[email protected]/cloudsplaining/output/dist/js/index.js

kmcquade added a commit to kmcquade/cloudsplaining that referenced this issue Oct 12, 2020
@kmcquade
Fixes salesforce#125 by adding --minimize option to the scan command
22329a3
verkaufer pushed a commit to verkaufer/cloudsplaining that referenced this issue Dec 10, 2020
@kmcquade @verkaufer
Added --minimize option to scan command to reduce report size (salesf…
7d54d2d 
…orce#126)

* Fixes salesforce#125 by adding --minimize option to the scan command

* Make the example report match the most recent version

* Make pylint happy

* Fix minimize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmcquade kmcquade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmcquade