Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced global type search, and prefs revisions #167

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

plaird
Copy link
Contributor

@plaird plaird commented Oct 7, 2020

Incremental work for #161

This is a substantial chunk of work on top of the hackathon feature 'global type search'. This does not finish it, but it moves it along quite a bit. Specifically:

  • it removes some of the hard coded logic for directory scanning
  • we now model the external jar tech stacks (but with only maven_install being fully fleshed out for now)
  • prefs revisions

It is disabled by default for now because I still don't fully understand the behaviors of maven_install with respect to when jars can be expected to be on the file system. It also needs further testing, and unit tests.

@plaird plaird assigned plaird and unassigned plaird Oct 7, 2020
@plaird plaird merged commit 01f8a8c into master Oct 7, 2020
@guw guw deleted the plaird/globalsearch branch May 1, 2021 16:09
@plaird
Copy link
Contributor Author

plaird commented Jul 19, 2021

"Open Any Type" aka "Global Classpath Search" was enabled by default in #261 (version 1.4.0). The preference remains, so it can be turned off if a user does not want it. I worry about performance on large repos (but I haven't tested it though), that is why someone might want to disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant