-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming JaccardDistance to JaccardSimilarity #80
Conversation
Thanks for the contribution! It looks like @tillbe is an internal user so signing the CLA is not required. However, we need to confirm this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=========================================
Coverage ? 85.95%
=========================================
Files ? 294
Lines ? 9547
Branches ? 551
=========================================
Hits ? 8206
Misses ? 1341
Partials ? 0
Continue to review full report at Codecov.
|
Related issues
https://gitter.im/salesforce-TransmogrifAI-Issues/Issues
JaccardSimilarity was wrongly named as JaccardDistance.
Describe the proposed solution
Renaming the function to its correct name.
Describe alternatives you've considered
Additional context