-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OS-neutral filesystem path creation #51
Conversation
Thanks for the contribution! Before we can merge this, we need @gerashegalov to sign the Salesforce.com Contributor License Agreement. |
@gerashegalov please make sure you replaced it everywhere in the code. |
fbb19d7
to
8dc1ec5
Compare
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 84.77% 84.77% +<.01%
==========================================
Files 298 298
Lines 9751 9753 +2
Branches 340 329 -11
==========================================
+ Hits 8266 8268 +2
Misses 1485 1485
Continue to review full report at Codecov.
|
fcb61a5
to
0f681af
Compare
@tovbinm It was my intent to replace all occurrences. lmk if I missed some. Classpath resources are fine to leave as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! We can run it on Windows :)
Better be friends with github owners 😃 |
Related issues
N/A
Describe the proposed solution
Avoid using explicit path separators
Describe alternatives you've considered
N/A
Additional context
N/A