Adding key ctor field in all RawFeatureFilter results
#348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelweilsalesforce
requested review from
leahmcguire and
tovbinm
as code owners
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
========================================
Coverage 86.65% 86.65%
========================================
Files 335 335
Lines 10763 10763
Branches 344 562 +218
========================================
Hits 9327 9327
Misses 1436 1436
Continue to review full report at Codecov.
|
sanmitra
suggested changes
Jun 28, 2019
michaelweilsalesforce
changed the title
key ctor field in all RawFeatureFilter resultskey ctor field in all RawFeatureFilter results
tovbinm
approved these changes
Jul 2, 2019
core/src/main/scala/com/salesforce/op/filters/RawFeatureFilterResults.scala
Outdated
Show resolved
Hide resolved
tovbinm
reviewed
Jul 2, 2019
core/src/main/scala/com/salesforce/op/filters/RawFeatureFilterResults.scala
Show resolved
Hide resolved
|
Thanks for the contribution! It looks like @mweilsalesforce is an internal user so signing the CLA is not required. However, we need to confirm this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
FeatureDistributioncontains the fieldkeywhich is the map key associated with distribution (when the feature is a map). But why not having the same field inRawFeatureFilterMetricsandExclusionReasons?Describe the proposed solution
Adding the same field in
RawFeatureFilterMetricsandExclusionReasonsDescribe alternatives you've considered
Additional context