Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Fix Alias Type Names #346

Merged
merged 4 commits into from
Jun 27, 2019
Merged

Quick Fix Alias Type Names #346

merged 4 commits into from
Jun 27, 2019

Conversation

michaelweilsalesforce
Copy link
Contributor

Related issues
When aliasing Type, the alias is sometimes lost in the reader.

Describe the proposed solution
Quick fix

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #346 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   86.65%   86.63%   -0.02%     
==========================================
  Files         335      335              
  Lines       10763    10763              
  Branches      344      568     +224     
==========================================
- Hits         9327     9325       -2     
- Misses       1436     1438       +2
Impacted Files Coverage Δ
.../main/scala/com/salesforce/op/readers/Reader.scala 85.71% <100%> (ø) ⬆️
...a/com/salesforce/op/readers/JoinedDataReader.scala 94.23% <100%> (ø) ⬆️
...es/src/main/scala/com/salesforce/op/OpParams.scala 85.71% <0%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e552147...75daedc. Read the comment docs.

Copy link
Collaborator

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tovbinm tovbinm merged commit 736df96 into master Jun 27, 2019
@tovbinm tovbinm deleted the mw/QuickFix branch June 27, 2019 19:35
This was referenced Jul 10, 2019
@salesforce-cla
Copy link

salesforce-cla bot commented Dec 2, 2020

Thanks for the contribution! It looks like @mweilsalesforce is an internal user so signing the CLA is not required. However, we need to confirm this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants