Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added concrete wrappers for HashingTF, NGram and StopWordsRemover #314

Merged
merged 2 commits into from
May 13, 2019

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented May 10, 2019

Related issues
These stages fail to serialize with changes in #274

Describe the proposed solution
Added concrete wrapping stages as for the rest of the stages + tests of course ;)

Describe alternatives you've considered
NA

@codecov
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #314 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   86.48%   86.51%   +0.03%     
==========================================
  Files         322      325       +3     
  Lines       10579    10581       +2     
  Branches      343      565     +222     
==========================================
+ Hits         9149     9154       +5     
+ Misses       1430     1427       -3
Impacted Files Coverage Δ
...force/op/stages/impl/feature/OpIndexToString.scala 100% <ø> (ø) ⬆️
...force/op/stages/impl/feature/OpStringIndexer.scala 100% <ø> (ø) ⬆️
...alesforce/op/stages/impl/feature/OpHashingTF.scala 100% <100%> (ø)
.../scala/com/salesforce/op/dsl/RichListFeature.scala 100% <100%> (+14.28%) ⬆️
...om/salesforce/op/stages/impl/feature/OpNGram.scala 100% <100%> (ø)
...ce/op/stages/impl/feature/OpStopWordsRemover.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976cd25...4fb3732. Read the comment docs.

Copy link
Contributor

@wsuchy wsuchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tovbinm tovbinm merged commit 3992cfe into master May 13, 2019
@tovbinm tovbinm deleted the mt/concrete-wrappers branch May 13, 2019 16:40
This was referenced Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants