-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved test SmartTextMapVectorizerTest #296
Conversation
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 86.4% 86.42% +0.01%
==========================================
Files 322 322
Lines 10572 10572
Branches 349 566 +217
==========================================
+ Hits 9135 9137 +2
+ Misses 1437 1435 -2
Continue to review full report at Codecov.
|
* Estimator instance to be tested | ||
*/ | ||
override val estimator: SmartTextMapVectorizer[TextMap] = new SmartTextMapVectorizer[TextMap]() | ||
.setMaxCardinality(2).setNumFeatures(4).setMinSupport(1).setTopK(2).setPrependFeatureName(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's perhaps test the stage with all the default settings, i.e. just val estimator: SmartTextMapVectorizer[TextMap] = new SmartTextMapVectorizer[TextMap]()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wsuchy can you please address my comment so we can merge this?
Thanks for the contribution! Before we can merge this, we need @wsuchy to sign the Salesforce.com Contributor License Agreement. |
Improved test by extending OpEstimatorSpec trait