Proper UID for Raw Feature Filter #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
========================================
Coverage 86.39% 86.39%
========================================
Files 319 319
Lines 10440 10440
Branches 349 544 +195
========================================
Hits 9020 9020
Misses 1420 1420
Continue to review full report at Codecov.
|
leahmcguire
reviewed
Apr 10, 2019
| @@ -592,6 +592,9 @@ object RawFeatureFilter { | |||
| // scoring sets since they will not be reliable. Currently, this is set to the same as the minimum training size. | |||
| val minScoringRowsDefault = 500 | |||
|
|
|||
| val stageName = classOf[RawFeatureFilter[_]].getSimpleName | |||
|
|
|||
| val uid = s"${stageName}_100000000000" | |||
There was a problem hiding this comment.
why not use the UID method?
There was a problem hiding this comment.
I guess it's better to have it be the same (!?) not important really, since there is only one.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
RFF has an invalid UID
Describe the proposed solution
Proper UID for Raw Feature Filter