Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out HasOut common trait #272

Merged
merged 4 commits into from
Apr 9, 2019
Merged

Factor out HasOut common trait #272

merged 4 commits into from
Apr 9, 2019

Conversation

tovbinm
Copy link
Collaborator

@tovbinm tovbinm commented Apr 9, 2019

Related issues
Following up on #269 - a sequence of PRs on allowing model loading without workflows...

Describe the proposed solution
Factored out common HasOut trait (similarly to HasIn that we have)

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #272 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #272      +/-   ##
==========================================
- Coverage    86.4%   86.36%   -0.04%     
==========================================
  Files         318      319       +1     
  Lines       10461    10431      -30     
  Branches      348      552     +204     
==========================================
- Hits         9039     9009      -30     
  Misses       1422     1422
Impacted Files Coverage Δ
...stages/base/quaternary/QuaternaryTransformer.scala 100% <ø> (ø) ⬆️
...la/com/salesforce/op/stages/OpPipelineStages.scala 63.51% <ø> (-11.95%) ⬇️
...c/main/scala/com/salesforce/op/stages/HasOut.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89723a...b85daa7. Read the comment docs.

@tovbinm tovbinm changed the title Added LambdaTransformer trait + factor out HasOut common trait Factor out HasOut common trait Apr 9, 2019
Copy link
Contributor

@wsuchy wsuchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@tovbinm tovbinm merged commit 7bcd1e4 into master Apr 9, 2019
@tovbinm tovbinm deleted the mt/lambda-trait branch April 9, 2019 22:08
@tovbinm tovbinm mentioned this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants