Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct some syntax/compilation errors in Titanic Binary Classification Docs Example #202

Merged
merged 3 commits into from
Jan 7, 2019

Conversation

crupley
Copy link
Contributor

@crupley crupley commented Jan 5, 2019

Related issues
#201

Describe the proposed solution
Corrections to the errors

Describe alternatives you've considered
None

Additional context
None

@salesforce-cla
Copy link

salesforce-cla bot commented Jan 5, 2019

Thanks for the contribution! It looks like @crupley is an internal user so signing the CLA is not required. However, we need to confirm this.

@crupley crupley changed the title Cr/titanic doc fix Correct some syntax/compilation errors in Titanic Binary Classification Docs Example Jan 5, 2019
@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #202 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage    86.4%   86.35%   -0.05%     
==========================================
  Files         309      309              
  Lines       10009    10009              
  Branches      351      557     +206     
==========================================
- Hits         8648     8643       -5     
- Misses       1361     1366       +5
Impacted Files Coverage Δ
.../salesforce/op/features/FeatureBuilderMacros.scala 0% <0%> (-100%) ⬇️
...es/src/main/scala/com/salesforce/op/OpParams.scala 85.71% <0%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04cd7ff...51ba812. Read the comment docs.

@tovbinm tovbinm merged commit e3d6189 into salesforce:master Jan 7, 2019
@crupley crupley deleted the cr/titanic-doc-fix branch January 7, 2019 18:42
@Jauntbox Jauntbox mentioned this pull request Feb 8, 2019
ericwayman pushed a commit that referenced this pull request Feb 8, 2019
@tovbinm tovbinm mentioned this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants