Add default param grid for xgboost #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinfaikan
changed the title
|
@kinfaikan please add xgboost to model selector enums and tests |
… into kk/xgbParamGrid
tovbinm
reviewed
Nov 6, 2018
| @@ -101,13 +101,15 @@ class BinaryClassificationModelSelectorTest extends FlatSpec with TestSparkConte | |||
|
|
|||
| Spec(BinaryClassificationModelSelector.getClass) should "properly select models to try" in { | |||
| val modelSelector = BinaryClassificationModelSelector | |||
| .withCrossValidation(modelTypesToUse = Seq(BMT.OpLogisticRegression, BMT.OpRandomForestClassifier)) | |||
| .setInput(label.asInstanceOf[Feature[RealNN]], features) | |||
| .withCrossValidation( | |||
There was a problem hiding this comment.
@kinfaikan please mixin OpXGBoostQuietLogging trait into tests to avoid unnecessary logging.
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
===========================================
+ Coverage 68.93% 86.28% +17.35%
===========================================
Files 305 305
Lines 9967 9977 +10
Branches 336 548 +212
===========================================
+ Hits 6871 8609 +1738
+ Misses 3096 1368 -1728
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
XGBoost does not have default param grid.
Describe the proposed solution
XGBoost has quite many hyperparameters. Consider only
numRound,eta,maxDepth, andminChildWeightin default param grid.Describe alternatives you've considered
NA
Additional context
NA