Added aggregate & conditonal readers for parquet #172
Conversation
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 86.3% 86.29% -0.02%
==========================================
Files 305 305
Lines 9963 9967 +4
Branches 339 548 +209
==========================================
+ Hits 8599 8601 +2
- Misses 1364 1366 +2
Continue to review full report at Codecov.
|
|
@ajayborra please add some tests. thanks. |
| readPath: Option[String], | ||
| key: T => String, | ||
| val conditionalParams: ConditionalParams[T] | ||
| )extends ParquetProductReader[T](readPath, key) with ConditionalDataReader[T] |
There was a problem hiding this comment.
please fix scalastyle warnings
There was a problem hiding this comment.
@tovbinm Seems like we have are going to have similar logic for testing these readers. Will look at the possibility of extracting these as Table Tests and update the PR.
There was a problem hiding this comment.
Any tests included? Why not?
|
@ajayborra Rachel is working on adding a common spec for all the readers, so dont sweat it too much ;) #83 |
Related issues
#56
Describe the proposed solution
Added Aggregate & Conditional Reader API for parquet format