-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return scoring feature distributions from RawFeatureFilter #171
Conversation
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 86.22% 86.25% +0.02%
==========================================
Files 305 305
Lines 9937 9950 +13
Branches 345 531 +186
==========================================
+ Hits 8568 8582 +14
+ Misses 1369 1368 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related issues
Scoring feature distributions are not exposed from
RawFeatureFilter
Describe the proposed solution
Return training and scoring feature distributions in single collection from
RawFeatureFilter
, but add a type to distinguish between them.type
enum field forFeatureDistribution
withTraining
andScoring
possible values.type
).Describe alternatives you've considered
Add an alternative collection with scoring feature distributions everywhere in RawFeatureFilter, OpWorkflow etc.
Additional context
This is an important piece of information that we don't want to loose ;)