Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circleci project setup #732

Closed
wants to merge 10 commits into from
Closed

Circleci project setup #732

wants to merge 10 commits into from

Conversation

ofayer
Copy link

@ofayer ofayer commented Oct 5, 2022

Please refer to our Commit Guidelines for documenting changes.

Changes proposed in this pull request:

Acceptance Criteria

General

  • Tested on desktop (see supported browsers)
  • Tested on mobile (for responsive or mobile-specific features)
  • Confirm Accessibility
  • Confirm RTL

Feature

  • Reference User Story work item number in description
  • Add usage examples
  • Add documentation for new usage guidelines
  • Add tests to test new components and implementation usage
  • Add component specific Release notes mentioning the changes
  • If feature requires the implementor to move to a new version, please provide a migration description in the component specific Release notes

Fix

  • Reference Bug work item number in description
  • Add tests to ensure bug does not happen again
  • Add component specific Release notes mentioning the changes

Design Changes

  • Add component specific Release notes mentioning the changes
  • If change requires the implementor to move to a new version, please provide a migration description in the component specific Release notes

Deprecated

  • If css selector is being deprecated, apply the @deprecate annotation to selector comment block

     /**
      * @selector .slds-bar
      * @deprecated
      */
     .slds-bar { ... }
  • If css selector is being deprecated, move deprecated code to _deprecate.scss file and wrap in deprecate mixin.

  • Provide deprecate mixin with version code will become deprecated and a brief description for what the code is being deprecated for.

     @include deprecate('4.0.0', 'Please use slds-foo instead of slds-bar') {
        .slds-bar { ... }
     }

@salesforce-cla
Copy link

salesforce-cla bot commented Oct 5, 2022

Thanks for the contribution! Before we can merge this, we need @ofayer to sign the Salesforce.com Contributor License Agreement.

@ofayer ofayer closed this by deleting the head repository Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant