Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

Add support for tenant-specific endpoints #129

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

JadeDickinson
Copy link

What

  • Adds support for tenant-specific endpoints by adding the class MarketingCloudSDK::ExactTargetEndpoints
  • This reads in tenant-specific values provided in the application using this gem.
  • Since these vary by organisation these can no longer be hardcoded in this gem.
  • Therefore this feature requires applications using this gem to add a file to their root directory, ./config/endpoints.yml, with the same keys as config/endpoints.yml from this gem.
  • Developers must then replace the placeholder values given with their tenant-specific endpoints for (SOAP)[https://help.salesforce.com/s/articleView?language=en_US&type=1&id=000356497] and (REST)[https://help.salesforce.com/s/articleView?id=000356498&type=1] endpoints.

Why

Addresses #123 and makes this gem usable from the end of September 2022.

Copy link

@jhonny-e-SB jhonny-e-SB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

have you been able to test this and make sure it works as expected?

class ExactTargetEndpoints
def self.config
YAML.load_file(
File.join('config', 'endpoints.yml')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe consider naming this marketing_cloud_endpoints or similar?
it's possible that applications that use this gem also use other 3rd parties, so just "endpoints" will not be specific enough

@@ -0,0 +1,25 @@
module MarketingCloudSDK
class ExactTargetEndpoints

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't Exact target name "deprecated"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, think I'll rename TenantSpecificEndpoints

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants