-
Notifications
You must be signed in to change notification settings - Fork 155
Add support for tenant-specific endpoints #129
base: master
Are you sure you want to change the base?
Add support for tenant-specific endpoints #129
Conversation
…d will be deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
have you been able to test this and make sure it works as expected?
class ExactTargetEndpoints | ||
def self.config | ||
YAML.load_file( | ||
File.join('config', 'endpoints.yml') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe consider naming this marketing_cloud_endpoints
or similar?
it's possible that applications that use this gem also use other 3rd parties, so just "endpoints" will not be specific enough
@@ -0,0 +1,25 @@ | |||
module MarketingCloudSDK | |||
class ExactTargetEndpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't Exact target
name "deprecated"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, think I'll rename TenantSpecificEndpoints
What
MarketingCloudSDK::ExactTargetEndpoints
./config/endpoints.yml
, with the same keys asconfig/endpoints.yml
from this gem.Why
Addresses #123 and makes this gem usable from the end of September 2022.