Magento2 quantity rounding #64
Merged
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbarley
requested review from
elliotlings,
Jamstaz,
JackGreen411,
brandonkyaw,
rickbairstow,
denizderman,
jordharris19,
ChrisWainwrightSalesfire and
EmilyScottSF
brandonkyaw
previously approved these changes
Dec 3, 2024
EmilyScottSF
previously approved these changes
Dec 3, 2024
Jamstaz
reviewed
Dec 4, 2024
michaelbarley
dismissed stale reviews from EmilyScottSF and brandonkyaw
via
661bcd3
brandonkyaw
approved these changes
Jan 6, 2025
JackGreen411
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When you don't specify the decimal places in
roundit rounds up,Work
I simply added 2 decimal places. Meaning quantity now comes in as 1.83 instead of 2.
Visual Evidence