Fix #9440 - Forcing default null value for numeric core fields.

[SinergiaCRM]

Rebased branch to hotfix from #9441

Closes #9440

Description

As described in the issue, non-custom/core non-required numeric fields aren't saving properly a default empty value in newly created modules.

Motivation and Context

(int) and (float) summoning always return 0 if the value is empty. Therefore we add a condition to return "null" if it's empty.

How To Test This

1. Create a new module in Module Builder
2. Add an Integer or Decimal field
3. Add the field to Edit and Detail View
4. Deploy module
5. Create a new record to the module, filling only the required name
6. Check that the numeric field has an empty value

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[clemente-raposo]

LGTM

[johnM2401]

Each of the four core number-type fields are rending as "null" when saved as empty now.

I have noticed that this same initial issue happens for other field-types too (ie, saving as " ", rather than NULL):

However, I assume this is fine as-is. (As the difference between 0 and NULL for numbers is more distinct)

Assuming this is okay, LGTM!

[gunnicom]

I think I fix this like this since years (I tried to integrate that in the original Sugar years ago)
Does take the "" => NULL into account, too.

diff --git a/include/database/DBManager.php b/include/database/DBManager.php
index 5d172ba93..0fe7644c4 100644
--- a/include/database/DBManager.php
+++ b/include/database/DBManager.php
@@ -543,7 +543,7 @@ abstract class DBManager
                     continue;
                 }

-                if (isset($data[$field])) {
+                if(isset($data[$field]) && (strlen($data[$field])>0 || $data[$field]===false)) { 
                     // clean the incoming value..
                     $val = from_html($data[$field]);
                 } else {