Get ChromeDriver's latest release in Robo task. #7345

connorshea · 2019-06-06T22:17:09Z

Description

This resolves one of the problems in #7344.

The Robo task will now automatically install the latest version of ChromeDriver instead of installing a static version.

Also improves wording/grammar in various places.

Motivation and Context

The ChromeDriver Robo task was stuck at an older version of ChromeDriver, 2.38. This isn't compatible with the latest release of Chrome, so it doesn't work unless you're on an older version of Chrome.

The LATEST_RELEASE URL system is based on how the webdrivers gem installs ChromeDriver, and also based on the ChromeDriver documentation.

How To Test This

Install ChromeDriver with the Robo task (./vendor/bin/robo chromedriver:install) and then make sure it runs properly (./vendor/bin/robo chromedriver:run). It should install ChromeDriver 75. You'll need to delete the existing build/tmp/webdrivers/ directory if you have one, or use ./vendor/bin/robo chromedriver:install --reinstall to delete the existing directory.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

My code follows the code style of this project found here.
My change requires a change to the documentation.
I have read the How to Contribute guidelines.

lib/Robo/Plugin/Commands/TestEnvironmentCommands.php

codecov-io · 2019-06-07T10:43:16Z

Codecov Report

❗ No coverage uploaded for pull request base (hotfix-7.10.x@be18dab). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             hotfix-7.10.x    #7345   +/-   ##
================================================
  Coverage                 ?    7.49%           
================================================
  Files                    ?     3741           
  Lines                    ?   387063           
  Branches                 ?        0           
================================================
  Hits                     ?    29025           
  Misses                   ?   358038           
  Partials                 ?        0

connorshea · 2019-06-07T14:49:16Z

@Dillon-Brown Updated

The Robo task will now automatically install the latest version of ChromeDriver instead of installing a static version. Also improves wording/grammar in various places.

connorshea · 2019-06-07T16:34:26Z

Rebased to squash the commits and to get Travis to re-run and hopefully not flake out this time.

Can be used to delete and reinstall the web driver. Also added a bit more logging and documentation.

connorshea · 2019-06-07T17:20:15Z

I added a --reinstall flag since ChromeDriver 75 came out today and I wanted to update to it without needing to manually delete the tmp directory :) I'll also add it to the documentation.

lib/Robo/Plugin/Commands/TestEnvironmentCommands.php

Dillon-Brown · 2019-06-10T10:23:20Z

lib/Robo/Plugin/Commands/TestEnvironmentCommands.php

+            }
+        } else if ($opts['reinstall']) {
+            $this->_deleteDir($basePath);
+            if (mkdir($basePath, 0777, true) === false) {


Suggested change

if (mkdir($basePath, 0777, true) === false) {

if (mkdir($basePath, 0777, true) || is_dir($basePath)) {

@Dillon-Brown This caused problems because if mkdir worked, the exception would be thrown. It'd also cause is_dir to return true, which also causes the exception.

lib/Robo/Plugin/Commands/TestEnvironmentCommands.php

Co-Authored-By: Dillon Brown <[email protected]>

connorshea · 2019-06-10T15:36:56Z

Updated 👍

connorshea · 2019-06-14T19:22:05Z

Two notes:

Using the LATEST_RELEASE URL to get the latest version without a major version specifier is deprecated (see also Chromedriver#latest_version now returns latest binary version corresponding to the installed Chrome version. titusfortner/webdrivers#32), we'll need to do something smarter to determine the currently-installed version and get a URL like LATEST_RELEASE_75. I don't think it's worth blocking this PR, but I'll need to fix it later.
The driver:run-chrome task should really be split into two separate tasks: chromedriver:install and chromedriver:run. I might make that change today.

Renames the commands to chromedriver:install and chromedriver:run.

Also movwes the Install command above the Run command.

…talled.

connorshea · 2019-06-17T20:31:10Z

I've split the command into two.

Also, this can probably be squashed when merged.

connorshea · 2019-06-18T21:24:18Z

It seems I got pretty unlucky with flaky tests on this one :P

Nothing I changed should effect the tests, and they match the flaky tests I've catalogued elsewhere.

connorshea · 2019-06-20T13:37:20Z

I think this is ready to go now.

connorshea · 2019-07-02T21:42:20Z

@Dillon-Brown any chance you could review? 😇

cameronblaikie · 2019-07-04T13:41:17Z

Assessed 👍

connorshea force-pushed the improve-chrome-webdriver-robo-task branch from 682099f to ad5a31d Compare June 6, 2019 22:18

connorshea mentioned this pull request Jun 6, 2019

Automated Testing improvements #7344

Closed

16 tasks

Dillon-Brown reviewed Jun 7, 2019

View reviewed changes

Dillon-Brown previously approved these changes Jun 7, 2019

View reviewed changes

connorshea mentioned this pull request Jun 7, 2019

Flaky tests #7272

Closed

Get ChromeDriver's latest release in Robo task.

95c4179

The Robo task will now automatically install the latest version of ChromeDriver instead of installing a static version. Also improves wording/grammar in various places.

connorshea dismissed Dillon-Brown’s stale review via 95c4179 June 7, 2019 16:33

connorshea force-pushed the improve-chrome-webdriver-robo-task branch from a7cc2e4 to 95c4179 Compare June 7, 2019 16:33

Add a --reinstall flag to the Chrome WebDriver task.

ba2ae28

Can be used to delete and reinstall the web driver. Also added a bit more logging and documentation.

Dillon-Brown added this to the 7.11.6 milestone Jun 10, 2019

Dillon-Brown approved these changes Jun 10, 2019

View reviewed changes

Dillon-Brown suggested changes Jun 10, 2019

View reviewed changes

Apply suggestions from code review

01470b9

Co-Authored-By: Dillon Brown <[email protected]>

Dillon-Brown previously approved these changes Jun 10, 2019

View reviewed changes

connorshea mentioned this pull request Jun 11, 2019

Robo test-running commands #7374

Merged

6 tasks

Dillon-Brown added the PR:Community Contribution These are contribution made by the community label Jun 12, 2019

Mac-Rae added the Status: Requires Code Review Needs the core team to code review label Jun 17, 2019

Split driver:run-chrome into two commands.

fcb063a

Renames the commands to chromedriver:install and chromedriver:run.

connorshea dismissed Dillon-Brown’s stale review via fcb063a June 17, 2019 20:02

connorshea added 4 commits June 17, 2019 14:06

Add a description for the url_base option.

3027a7f

Also movwes the Install command above the Run command.

Fix function names for ChromeDriver commands.

18f2351

Update command output when the driver has already been downloaded/ins…

2193fb1

…talled.

Fix ChromeDriver reinstall flag.

d876bfa

Dillon-Brown approved these changes Jul 4, 2019

View reviewed changes

Dillon-Brown removed the Status: Requires Code Review Needs the core team to code review label Jul 4, 2019

cameronblaikie added the Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member label Jul 4, 2019

Dillon-Brown merged commit a0d5f5a into salesagility:hotfix-7.10.x Jul 4, 2019

connorshea mentioned this pull request Jul 9, 2019

Update Automated Testing documentation. salesagility/SuiteDocs#300

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get ChromeDriver's latest release in Robo task. #7345

Get ChromeDriver's latest release in Robo task. #7345

connorshea commented Jun 6, 2019 •

edited

Loading

codecov-io commented Jun 7, 2019 •

edited

Loading

connorshea commented Jun 7, 2019

connorshea commented Jun 7, 2019

connorshea commented Jun 7, 2019

Dillon-Brown Jun 10, 2019

connorshea Jun 17, 2019

connorshea commented Jun 10, 2019

connorshea commented Jun 14, 2019

connorshea commented Jun 17, 2019 •

edited

Loading

connorshea commented Jun 18, 2019

connorshea commented Jun 20, 2019

connorshea commented Jul 2, 2019

cameronblaikie commented Jul 4, 2019

	if (mkdir($basePath, 0777, true) === false) {
	if (mkdir($basePath, 0777, true) \|\| is_dir($basePath)) {

Get ChromeDriver's latest release in Robo task. #7345

Get ChromeDriver's latest release in Robo task. #7345

Conversation

connorshea commented Jun 6, 2019 • edited Loading

Description

Motivation and Context

How To Test This

Types of changes

Final checklist

codecov-io commented Jun 7, 2019 • edited Loading

Codecov Report

connorshea commented Jun 7, 2019

connorshea commented Jun 7, 2019

connorshea commented Jun 7, 2019

Dillon-Brown Jun 10, 2019

Choose a reason for hiding this comment

connorshea Jun 17, 2019

Choose a reason for hiding this comment

connorshea commented Jun 10, 2019

connorshea commented Jun 14, 2019

connorshea commented Jun 17, 2019 • edited Loading

connorshea commented Jun 18, 2019

connorshea commented Jun 20, 2019

connorshea commented Jul 2, 2019

cameronblaikie commented Jul 4, 2019

connorshea commented Jun 6, 2019 •

edited

Loading

codecov-io commented Jun 7, 2019 •

edited

Loading

connorshea commented Jun 17, 2019 •

edited

Loading