Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing to display the labels on each column to line items #349

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

jsanchezL
Copy link

Fixing to loading and display labels in each column to line items as expected.

Description

When I been use the last version of CRM in the module Quotes I try made a new quote at the moment click add new line the title in each column showed 'undefined' the same case to the fields totals

I opened the code inspector in my web explorer so to inspected why displayed the 'undefined' when I located the object where I supposed the labels must retrieve after a couple test I been never get any expected result.

I made a couple test to load the labels to this part and I overwrite this code to folder 'custom' and works fine to me.

Motivation and Context

I needed to customize module how part a solution to customer.
With this fix loading fine the labels to each column line items and displayed correctly now

How To Test This

Well I been testing the changes when I make a new Quote and I clicking to add new line item and now view the label correctly to each column and total fields

Types of changes

  • [ X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

I was fix it to loading and display labels in each column to line items as expected.
@SuiteBot
Copy link

SuiteBot commented Sep 20, 2023

CLA assistant check
All committers have signed the CLA.

@clemente-raposo
Copy link
Contributor

Hi @jsanchezL ,

Thank you for your PR.

Repo change

salesagility/SuiteCRM-Core repo uses salesagility/SuiteCRM as a subrepo, which allows SuiteCRM 8 to re-use SuiteCRM 7 code base and also get new feaures and fixes from SuiteCRM 7.

Since this fix is on legacy Quotes Line items it is also applicable to 7.14. Would you have a chance to re-create in the https://github.com/salesagility/SuiteCRM repo, please?

It would be the best approach as we would fix the issue on SuiteCRM 7 and on SuiteCRM 8 with just on PR.

Add Fix# on the commit

Could add Fix#<issue number> on the commit please?

@clemente-raposo clemente-raposo added the Status:Requires Updates Issues & PRs which requires input or update from the author label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Requires Updates Issues & PRs which requires input or update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants