Fix #321 - Make fields full span #322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemente-raposo
added
the
Status: Team Investigating
mpuyosa91
force-pushed
the
fix/321_make_field_full_span
branch
from
e4c2b68
to
b44aef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Border has been removed in field-layout-component and fillRow(row) because it was dividing row in two seperate columns.
field-layout .field-column-borderedclass has been removed in field-layout scss because it was not being used anymore. #321Motivation and Context
When set a field to span across both columns, the field is expected spans across both columns in Detail / Edit View.
How To Test This
In Studio, if you set a field to span across both columns, when you check this in the Detail / Edit View, the field spans across two column.
Types of changes
Final checklist